Skip to content

Increase timeout for blurTimeout#811

Closed
boldtrn wants to merge 1 commit into
devbridge:masterfrom
boldtrn:patch-1
Closed

Increase timeout for blurTimeout#811
boldtrn wants to merge 1 commit into
devbridge:masterfrom
boldtrn:patch-1

Conversation

@boldtrn
Copy link
Copy Markdown

@boldtrn boldtrn commented Dec 29, 2020

Fixes #809. If someone is a "slow clicker" it can happen that the autocomplete selection is closed instead of triggering the click event. You can try this when holding the left mouse button for a short time, this increases the timeout a bit to make it more likely that the click event is triggered.

Daniel-KM pushed a commit to Daniel-KM/Omeka-S-module-AdvancedSearch that referenced this pull request Sep 29, 2021
Daniel-KM pushed a commit to Daniel-KM/Omeka-S-module-AdvancedSearch that referenced this pull request Oct 20, 2021
@bjammin
Copy link
Copy Markdown

bjammin commented Oct 13, 2022

Thanks for the fix.

However is there anyway the blur function could be aware of the target of the click, and not hide the autocomplete if it is the target?

@tkirda
Copy link
Copy Markdown
Member

tkirda commented May 20, 2026

Thanks for this contribution, and apologies for the very long silence.

The project was dormant for several years and has just shipped v2.0, which is a ground-up TypeScript rewrite with a new build (esbuild), test runner (Vitest + jsdom), and CI pipeline. As a result this PR no longer applies cleanly against master, and the surrounding code it touches has changed enough that mechanically rebasing it wouldn't be safe.

I'm closing it as part of a triage pass on the long-stale PR backlog — not because the idea lacks merit. If this change is still valuable to you against 2.0, please open a fresh PR (or an issue first if you'd like to confirm direction); I'll review new submissions against the current codebase promptly.

Thanks again for taking the time.

@tkirda tkirda closed this May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking on the list does not select the item

3 participants